Repository navigation
test(perry): serialize the two sandbox_buildrs tests that race on PERRY_SANDBOX_BUILDRS - #11345
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughBoth sandbox buildrs tests now acquire the shared environment lock before changing ChangesSandbox buildrs test environment
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to Both tests now serialize changes to PERRY_SANDBOX_BUILDRS, preventing their parallel environment race. The change is limited to tests and a changelog entry, with no actionable merge risk identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description provides a clear technical summary and reports a focused test result, but it does not use the required Summary, Changes, Related issue, Test plan, Screenshots / output, and Checklist sections. Resolution Rewrite the description using the repository template. Add the required section headings, list the concrete changes, state the related issue or "n/a", document the test commands and results, complete the applicable checklist items, and include screenshots or output when applicable.
✨ Finishing Touches 💡 1📝 Generate docstrings
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
wrap_cargo_falls_through_when_sandbox_disabledremovesPERRY_SANDBOX_BUILDRSand asserts the plaincargopath, while its siblingwrap_cargo_falls_through_when_package_exemptsets it to1at the same time on another test thread. When the two interleave, the first one sees the sandbox enabled and fails atsandbox_buildrs.rs:254(seen in a localcargo test -p perry --bin perrystack check, 1202/1).Both tests now take
crate::test_env_lock::env_lock(), the crate's shared env mutex. Test-only change.cargo test -p perry --bin perry sandbox_buildrspassed 5/5.Summary by CodeRabbit